Home | Notifications | New Note | Local | Federated | Search | Logout

Note Detail

Reply to @silverpill@mitra.social
Phantasm@phnt@fluffytail.org (2026-06-14 21:28:22)
@silverpill You ideally should verify that AcceptFeatured refers to the type of the Object as expected, effectively doing the same thing anyway. You also need to add that as a supported type to your Acccept/Reject validator since they are basically the same, you have to modify your activity builder, if you have one, to create these new types if you wish to support creation and not just ingestion.

So instead of some long switch/case statement on an Object type, you now have a long list of Accept*/Reject* types that all have the same semantics just operating on different types. And more handling in your validators/builders.

The same argument can be made about Create/Update Activities which operate on a bunch of Object types. CreateNote/UpdateNote/UpdateActor/... doesn't make sense in my head as well.
---Reply---
silverpill@silverpill@mitra.social (2026-06-14 22:18:42)
@phnt

You ideally should verify that AcceptFeatured refers to the type of the Object as expected, effectively doing the same thing anyway.

It is not the same thing because you skip one expensive operation: determining the subtype of activity.

You also need to add that as a supported type to your Acccept/Reject validator since they are basically the same, you have to modify your activity builder, if you have one, to create these new types if you wish to support creation and not just ingestion.

Is that a problem? I already have different parsers and different builders for different activities.

The same argument can be made about Create/Update Activities which operate on a bunch of Object types. CreateNote/UpdateNote/UpdateActor/... doesn't make sense in my head as well.

Create and Update have an embedded object, so they do not require specialized names.